aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net
diff options
context:
space:
mode:
authorYang Yingliang <yangyingliang@huawei.com>2021-06-26 12:44:20 +0800
committerDavid S. Miller <davem@davemloft.net>2021-06-28 14:20:23 -0700
commit83300c69e797343c560086b1a4be56443c0d7f5e (patch)
tree7d8f76825cc9361a0c55ca87288120240d706b33 /drivers/net
parentnet: sparx5: fix return value check in sparx5_create_targets() (diff)
downloadlinux-dev-83300c69e797343c560086b1a4be56443c0d7f5e.tar.xz
linux-dev-83300c69e797343c560086b1a4be56443c0d7f5e.zip
net: sparx5: fix error return code in sparx5_register_notifier_blocks()
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: d6fce5141929 ("net: sparx5: add switching support") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
-rw-r--r--drivers/net/ethernet/microchip/sparx5/sparx5_switchdev.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_switchdev.c b/drivers/net/ethernet/microchip/sparx5/sparx5_switchdev.c
index 246eba711f15..a72e3b3b596e 100644
--- a/drivers/net/ethernet/microchip/sparx5/sparx5_switchdev.c
+++ b/drivers/net/ethernet/microchip/sparx5/sparx5_switchdev.c
@@ -485,8 +485,10 @@ int sparx5_register_notifier_blocks(struct sparx5 *s5)
goto err_switchdev_blocking_nb;
sparx5_owq = alloc_ordered_workqueue("sparx5_order", 0);
- if (!sparx5_owq)
+ if (!sparx5_owq) {
+ err = -ENOMEM;
goto err_switchdev_blocking_nb;
+ }
return 0;