aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net
diff options
context:
space:
mode:
authorWei Yongjun <weiyongjun1@huawei.com>2019-07-05 01:16:42 +0000
committerDavid S. Miller <davem@davemloft.net>2019-07-07 19:25:36 -0700
commit877cb240f6a000078aabcd57f8ef7765d9fdf134 (patch)
treefab183eed4de5a48657a2b75f54c81bb1364490a /drivers/net
parentMerge branch 'net-dsa-Add-Vitesse-VSC73xx-parallel-mode' (diff)
downloadlinux-dev-877cb240f6a000078aabcd57f8ef7765d9fdf134.tar.xz
linux-dev-877cb240f6a000078aabcd57f8ef7765d9fdf134.zip
gve: Fix error return code in gve_alloc_qpls()
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: f5cedc84a30d ("gve: Add transmit and receive support") Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
-rw-r--r--drivers/net/ethernet/google/gve/gve_main.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/ethernet/google/gve/gve_main.c b/drivers/net/ethernet/google/gve/gve_main.c
index eef500bd2ff7..24f16e3368cd 100644
--- a/drivers/net/ethernet/google/gve/gve_main.c
+++ b/drivers/net/ethernet/google/gve/gve_main.c
@@ -625,8 +625,10 @@ static int gve_alloc_qpls(struct gve_priv *priv)
sizeof(unsigned long) * BITS_PER_BYTE;
priv->qpl_cfg.qpl_id_map = kvzalloc(BITS_TO_LONGS(num_qpls) *
sizeof(unsigned long), GFP_KERNEL);
- if (!priv->qpl_cfg.qpl_id_map)
+ if (!priv->qpl_cfg.qpl_id_map) {
+ err = -ENOMEM;
goto free_qpls;
+ }
return 0;