diff options
| author |   Leon Romanovsky <leonro@mellanox.com> | 2016-12-29 18:37:11 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2016-12-29 14:17:40 -0500 |
| commit | c1d5f8ff80ea84768f5fae1ca9d1abfbb5e6bbaa (patch) | |
| tree | 3ae821917376b0453fb0687f55b9dc4194cf2e0e /drivers/net | |
| parent | net/mlx4_en: Fix bad WQE issue (diff) | |
| download | linux-dev-c1d5f8ff80ea84768f5fae1ca9d1abfbb5e6bbaa.tar.xz linux-dev-c1d5f8ff80ea84768f5fae1ca9d1abfbb5e6bbaa.zip | |
net/mlx4: Remove BUG_ON from ICM allocation routine
This patch removes BUG_ON() macro from mlx4_alloc_icm_coherent()
by checking DMA address alignment in advance and performing proper
folding in case of error.
Fixes: 5b0bf5e25efe ("mlx4_core: Support ICM tables in coherent memory")
Reported-by: Ozgur Karatas <okaratas@member.fsf.org>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/ethernet/mellanox/mlx4/icm.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/drivers/net/ethernet/mellanox/mlx4/icm.c b/drivers/net/ethernet/mellanox/mlx4/icm.c index 2a9dd460a95f..e1f9e7cebf8f 100644 --- a/drivers/net/ethernet/mellanox/mlx4/icm.c +++ b/drivers/net/ethernet/mellanox/mlx4/icm.c @@ -118,8 +118,13 @@ static int mlx4_alloc_icm_coherent(struct device *dev, struct scatterlist *mem, if (!buf) return -ENOMEM; + if (offset_in_page(buf)) { + dma_free_coherent(dev, PAGE_SIZE << order, + buf, sg_dma_address(mem)); + return -ENOMEM; + } + sg_set_buf(mem, buf, PAGE_SIZE << order); - BUG_ON(mem->offset); sg_dma_len(mem) = PAGE_SIZE << order; return 0; } |