diff options
| author |   Jian Shen <shenjian15@huawei.com> | 2019-03-06 11:26:37 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-03-08 14:42:37 -0800 |
| commit | d394d33bee22421b39a0bcdc51ca6d68ba308625 (patch) | |
| tree | 11e4c9faa587ce162314f53b255e79f423735d8b /drivers/net | |
| parent | net: add missing documentation in linux/skbuff.h (diff) | |
| download | linux-dev-d394d33bee22421b39a0bcdc51ca6d68ba308625.tar.xz linux-dev-d394d33bee22421b39a0bcdc51ca6d68ba308625.zip | |
net: hns3: add dma_rmb() for rx description
HW can not guarantee complete write desc->rx.size, even though
HNS3_RXD_VLD_B has been set. Driver needs to add dma_rmb()
instruction to make sure desc->rx.size is always valid.
Fixes: e55970950556 ("net: hns3: Add handling of GRO Pkts not fully RX'ed in NAPI poll")
Signed-off-by: Jian Shen <shenjian15@huawei.com>
Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c index 1e4efc47c7a5..0d1ae15a5927 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c @@ -2472,6 +2472,8 @@ static int hns3_add_frag(struct hns3_enet_ring *ring, struct hns3_desc *desc, desc = &ring->desc[ring->next_to_clean]; desc_cb = &ring->desc_cb[ring->next_to_clean]; bd_base_info = le32_to_cpu(desc->rx.bd_base_info); + /* make sure HW write desc complete */ + dma_rmb(); if (!(bd_base_info & BIT(HNS3_RXD_VLD_B))) return -ENXIO; |