diff options
| author |   Antoine Tenart <antoine.tenart@bootlin.com> | 2020-06-25 17:42:10 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2020-06-25 16:22:11 -0700 |
| commit | d4a76dc74dff76c4d7f193806f336899fb8e5016 (patch) | |
| tree | 3658078f284764b49e33a697d4bf2c3513c95801 /drivers/net | |
| parent | net: phy: mscc: restore the base page in vsc8514/8584_config_init (diff) | |
| download | linux-dev-d4a76dc74dff76c4d7f193806f336899fb8e5016.tar.xz linux-dev-d4a76dc74dff76c4d7f193806f336899fb8e5016.zip | |
net: phy: mscc: remove useless page configuration in the config init
In the middle of vsc8584_config_init and vsc8514_config_init, the page
is set to 'standard'. This is the default value, and the page isn't set
to another value before. Those pages configuration can be safely
removed.
Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/phy/mscc/mscc_main.c | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/drivers/net/phy/mscc/mscc_main.c b/drivers/net/phy/mscc/mscc_main.c index f625109df00a..04e1ef791cec 100644 --- a/drivers/net/phy/mscc/mscc_main.c +++ b/drivers/net/phy/mscc/mscc_main.c @@ -1443,8 +1443,6 @@ static int vsc8584_config_init(struct phy_device *phydev) if (ret) return ret; - phy_write(phydev, MSCC_EXT_PAGE_ACCESS, MSCC_PHY_PAGE_STANDARD); - val = phy_read(phydev, MSCC_PHY_EXT_PHY_CNTL_1); val &= ~(MEDIA_OP_MODE_MASK | VSC8584_MAC_IF_SELECTION_MASK); val |= (MEDIA_OP_MODE_COPPER << MEDIA_OP_MODE_POS) | @@ -1892,11 +1890,6 @@ static int vsc8514_config_init(struct phy_device *phydev) phy_unlock_mdio_bus(phydev); - ret = phy_write(phydev, MSCC_EXT_PAGE_ACCESS, MSCC_PHY_PAGE_STANDARD); - - if (ret) - return ret; - ret = phy_modify(phydev, MSCC_PHY_EXT_PHY_CNTL_1, MEDIA_OP_MODE_MASK, MEDIA_OP_MODE_COPPER << MEDIA_OP_MODE_POS); |