diff options
| author |   Fabio Estevam <fabio.estevam@freescale.com> | 2014-06-03 19:55:38 -0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2014-06-05 15:03:46 -0700 |
| commit | d4c642ea1239f0c5c1d794a5b788319d3373c58c (patch) | |
| tree | fefa5990e0a8cdfa5ce21b997297805fc6b68592 /drivers/net | |
| parent | ipv6: Fix regression caused by efe4208 in udp_v6_mcast_next() (diff) | |
| download | linux-dev-d4c642ea1239f0c5c1d794a5b788319d3373c58c.tar.xz linux-dev-d4c642ea1239f0c5c1d794a5b788319d3373c58c.zip | |
gianfar: Call netif_carrier_off() prior to registration
Quoting David Miller:
"At the moment you call register_netdev() the device is visible, notifications
are sent to userspace, and userland tools can try to bring the interface up
and see the incorrect link state, before you do the netif_carrier_off().
Said another way, between the register_netdev() and netif_carrier_off() call,
userspace can see the device in an inconsistent state."
So call netif_carrier_off() prior to register_netdev().
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/ethernet/freescale/gianfar.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c index e2d42475b006..c81625ade4a3 100644 --- a/drivers/net/ethernet/freescale/gianfar.c +++ b/drivers/net/ethernet/freescale/gianfar.c @@ -1373,6 +1373,9 @@ static int gfar_probe(struct platform_device *ofdev) gfar_hw_init(priv); + /* Carrier starts down, phylib will bring it up */ + netif_carrier_off(dev); + err = register_netdev(dev); if (err) { @@ -1380,9 +1383,6 @@ static int gfar_probe(struct platform_device *ofdev) goto register_fail; } - /* Carrier starts down, phylib will bring it up */ - netif_carrier_off(dev); - device_init_wakeup(&dev->dev, priv->device_flags & FSL_GIANFAR_DEV_HAS_MAGIC_PACKET); |