diff options
| author |   Logan Gunthorpe <logang@deltatee.com> | 2017-06-05 14:00:52 -0600 |
|---|---|---|
| committer |   Jon Mason <jdmason@kudzu.us> | 2017-06-19 14:24:41 -0400 |
| commit | cb827ee6ccc3e480f0d9c0e8e53eef55be5b0414 (patch) | |
| tree | 4236fb39fbd427165810e0980bd4fa34e0d20f6d /drivers/ntb | |
| parent | NTB: ntb_test: fix bug printing ntb_perf results (diff) | |
| download | linux-dev-cb827ee6ccc3e480f0d9c0e8e53eef55be5b0414.tar.xz linux-dev-cb827ee6ccc3e480f0d9c0e8e53eef55be5b0414.zip | |
ntb_transport: fix qp count bug
In cases where there are more mw's than spads/2-2, the mw count gets
reduced to match the limitation. ntb_transport also tries to ensure that
there are fewer qps than mws but uses the full mw count instead of
the reduced one. When this happens, the math in
'ntb_transport_setup_qp_mw' will get confused and result in a kernel
paging request bug.
This patch fixes the bug by reducing qp_count to the reduced mw count
instead of the full mw count.
Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
Fixes: e26a5843f7f5 ("NTB: Split ntb_hw_intel and ntb_transport drivers")
Acked-by: Allen Hubbe <Allen.Hubbe@dell.com>
Signed-off-by: Jon Mason <jdmason@kudzu.us>
Diffstat (limited to 'drivers/ntb')
| -rw-r--r-- | drivers/ntb/ntb_transport.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c index 02ca45fdd892..0a778d2cab94 100644 --- a/drivers/ntb/ntb_transport.c +++ b/drivers/ntb/ntb_transport.c @@ -1128,8 +1128,8 @@ static int ntb_transport_probe(struct ntb_client *self, struct ntb_dev *ndev) qp_count = ilog2(qp_bitmap); if (max_num_clients && max_num_clients < qp_count) qp_count = max_num_clients; - else if (mw_count < qp_count) - qp_count = mw_count; + else if (nt->mw_count < qp_count) + qp_count = nt->mw_count; qp_bitmap &= BIT_ULL(qp_count) - 1; |