diff options
| author |   Vivek Goyal <vgoyal@redhat.com> | 2020-04-01 12:11:25 -0400 |
|---|---|---|
| committer |   Dan Williams <dan.j.williams@intel.com> | 2020-04-02 19:15:03 -0700 |
| commit | 4e4ced93794acb42adb19484132966defba8f3a6 (patch) | |
| tree | 2a63f73c19e052bb5b7fa283545cd9349447d21e /drivers/nvdimm | |
| parent | dax,iomap: Add helper dax_iomap_zero() to zero a range (diff) | |
| download | linux-dev-4e4ced93794acb42adb19484132966defba8f3a6.tar.xz linux-dev-4e4ced93794acb42adb19484132966defba8f3a6.zip | |
dax: Move mandatory ->zero_page_range() check in alloc_dax()
zero_page_range() dax operation is mandatory for dax devices. Right now
that check happens in dax_zero_page_range() function. Dan thinks that's
too late and its better to do the check earlier in alloc_dax().
I also modified alloc_dax() to return pointer with error code in it in
case of failure. Right now it returns NULL and caller assumes failure
happened due to -ENOMEM. But with this ->zero_page_range() check, I
need to return -EINVAL instead.
Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
Link: https://lore.kernel.org/r/20200401161125.GB9398@redhat.com
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Diffstat (limited to 'drivers/nvdimm')
| -rw-r--r-- | drivers/nvdimm/pmem.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c index 5b774ddd0efb..715cb0696525 100644 --- a/drivers/nvdimm/pmem.c +++ b/drivers/nvdimm/pmem.c @@ -487,9 +487,9 @@ static int pmem_attach_disk(struct device *dev, if (is_nvdimm_sync(nd_region)) flags = DAXDEV_F_SYNC; dax_dev = alloc_dax(pmem, disk->disk_name, &pmem_dax_ops, flags); - if (!dax_dev) { + if (IS_ERR(dax_dev)) { put_disk(disk); - return -ENOMEM; + return PTR_ERR(dax_dev); } dax_write_cache(dax_dev, nvdimm_has_cache(nd_region)); pmem->dax_dev = dax_dev; |