diff options
| author |   James Smart <jsmart2021@gmail.com> | 2018-05-11 17:50:22 -0700 |
|---|---|---|
| committer |   Christoph Hellwig <hch@lst.de> | 2018-05-25 16:50:15 +0200 |
| commit | ffecb0b452d5cbdd2ac3614bdf6cd39ba47b0cb8 (patch) | |
| tree | 2bb46f2d808eeeb9165ffaddeb80da36920ff352 /drivers/nvme/host/fabrics.c | |
| parent | nvme-fc: remove setting DNR on exception conditions (diff) | |
| download | linux-dev-ffecb0b452d5cbdd2ac3614bdf6cd39ba47b0cb8.tar.xz linux-dev-ffecb0b452d5cbdd2ac3614bdf6cd39ba47b0cb8.zip | |
nvme-fabrics: remove unnecessary controller subnqn validation
After creating the nvme controller, nvmf_create_ctrl() validates
the newly created subsysnqn vs the one specified by the options.
In general, this is an unnecessary check as the Connect message
should implicitly ensure this value matches.
With the change to the FC transport to do an asynchronous connect
for the first association create, the transport will return to
nvmf_create_ctrl() before that first association has been established,
thus the subnqn will not yet be set.
Remove the unnecessary validation.
Signed-off-by: James Smart <james.smart@broadcom.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'drivers/nvme/host/fabrics.c')
| -rw-r--r-- | drivers/nvme/host/fabrics.c | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/drivers/nvme/host/fabrics.c b/drivers/nvme/host/fabrics.c index 7ae732a77fe8..6fdf499d16b4 100644 --- a/drivers/nvme/host/fabrics.c +++ b/drivers/nvme/host/fabrics.c @@ -983,16 +983,6 @@ nvmf_create_ctrl(struct device *dev, const char *buf, size_t count) goto out_module_put; } - if (strcmp(ctrl->subsys->subnqn, opts->subsysnqn)) { - dev_warn(ctrl->device, - "controller returned incorrect NQN: \"%s\".\n", - ctrl->subsys->subnqn); - module_put(ops->module); - up_read(&nvmf_transports_rwsem); - nvme_delete_ctrl_sync(ctrl); - return ERR_PTR(-EINVAL); - } - module_put(ops->module); up_read(&nvmf_transports_rwsem); return ctrl; |