diff options
| author |   James Smart <jsmart2021@gmail.com> | 2020-03-31 09:49:49 -0700 |
|---|---|---|
| committer |   Jens Axboe <axboe@kernel.dk> | 2020-05-09 16:18:33 -0600 |
| commit | 3b8281b02bdc6fc7bed6f20af6fd7933a86b94e2 (patch) | |
| tree | c6c6dccf3f4293d717d4ba87c33cd33e8f1e75e5 /drivers/nvme/host/fc.h | |
| parent | nvme-fc nvmet-fc: refactor for common LS definitions (diff) | |
| download | linux-dev-3b8281b02bdc6fc7bed6f20af6fd7933a86b94e2.tar.xz linux-dev-3b8281b02bdc6fc7bed6f20af6fd7933a86b94e2.zip | |
nvmet-fc: Better size LS buffers
Current code uses NVME_FC_MAX_LS_BUFFER_SIZE (2KB) when allocating
buffers for LS requests and responses. This is considerable overkill
for what is actually defined.
Rework code to have unions for all possible requests and responses
and size based on the unions. Remove NVME_FC_MAX_LS_BUFFER_SIZE.
Signed-off-by: James Smart <jsmart2021@gmail.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/nvme/host/fc.h')
| -rw-r--r-- | drivers/nvme/host/fc.h | 15 |
1 files changed, 15 insertions, 0 deletions
diff --git a/drivers/nvme/host/fc.h b/drivers/nvme/host/fc.h index d2861cdd58ee..08fa88381d45 100644 --- a/drivers/nvme/host/fc.h +++ b/drivers/nvme/host/fc.h @@ -16,6 +16,21 @@ * ****************** FC-NVME LS HANDLING ****************** */ +union nvmefc_ls_requests { + struct fcnvme_ls_cr_assoc_rqst rq_cr_assoc; + struct fcnvme_ls_cr_conn_rqst rq_cr_conn; + struct fcnvme_ls_disconnect_assoc_rqst rq_dis_assoc; + struct fcnvme_ls_disconnect_conn_rqst rq_dis_conn; +} __aligned(128); /* alignment for other things alloc'd with */ + +union nvmefc_ls_responses { + struct fcnvme_ls_rjt rsp_rjt; + struct fcnvme_ls_cr_assoc_acc rsp_cr_assoc; + struct fcnvme_ls_cr_conn_acc rsp_cr_conn; + struct fcnvme_ls_disconnect_assoc_acc rsp_dis_assoc; + struct fcnvme_ls_disconnect_conn_acc rsp_dis_conn; +} __aligned(128); /* alignment for other things alloc'd with */ + static inline void nvme_fc_format_rsp_hdr(void *buf, u8 ls_cmd, __be32 desc_len, u8 rqst_ls_cmd) { |