diff options
| author |   Keith Busch <keith.busch@intel.com> | 2018-04-12 09:16:08 -0600 |
|---|---|---|
| committer |   Jens Axboe <axboe@kernel.dk> | 2018-04-12 09:58:27 -0600 |
| commit | 64ee0ac0527704c47170316fa58dbde50edaaf70 (patch) | |
| tree | f362e9b1727897b8f4b6ec1e4ade171328057910 /drivers/nvme/host | |
| parent | nvme: target: fix buffer overflow (diff) | |
| download | linux-dev-64ee0ac0527704c47170316fa58dbde50edaaf70.tar.xz linux-dev-64ee0ac0527704c47170316fa58dbde50edaaf70.zip | |
nvme-pci: Skip queue deletion if there are no queues
User reported controller always retains CSTS.RDY to 1, which fails
controller disabling when resetting the controller. This is also before
the admin queue is allocated, and trying to disable an unallocated queue
results in a NULL dereference.
Reported-by: Alex Gagniuc <Alex_Gagniuc@Dellteam.com>
Signed-off-by: Keith Busch <keith.busch@intel.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/nvme/host')
| -rw-r--r-- | drivers/nvme/host/pci.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index 295fbec1e5f2..22403aa7dc60 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -2201,7 +2201,7 @@ static void nvme_dev_disable(struct nvme_dev *dev, bool shutdown) nvme_stop_queues(&dev->ctrl); - if (!dead) { + if (!dead && dev->ctrl.queue_count > 0) { /* * If the controller is still alive tell it to stop using the * host memory buffer. In theory the shutdown / reset should |