diff options
| author |   Luis Chamberlain <mcgrof@kernel.org> | 2021-08-30 14:25:33 -0700 |
|---|---|---|
| committer |   Christoph Hellwig <hch@lst.de> | 2021-09-06 10:08:09 +0200 |
| commit | ab3994f6efba95e0832dc9e68c088b2d7ae764b8 (patch) | |
| tree | 184c4aab04d26482cb9431b082fd7bcfbb95527c /drivers/nvme/host | |
| parent | nvme: only call synchronize_srcu when clearing current path (diff) | |
| download | linux-dev-ab3994f6efba95e0832dc9e68c088b2d7ae764b8.tar.xz linux-dev-ab3994f6efba95e0832dc9e68c088b2d7ae764b8.zip | |
nvme: add error handling support for add_disk()
We never checked for errors on add_disk() as this function
returned void. Now that this is fixed, use the shiny new
error handling.
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'drivers/nvme/host')
| -rw-r--r-- | drivers/nvme/host/core.c | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index 4a3a33f5f11c..7efb31b87f37 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -3798,7 +3798,9 @@ static void nvme_alloc_ns(struct nvme_ctrl *ctrl, unsigned nsid, nvme_get_ctrl(ctrl); - device_add_disk(ctrl->device, ns->disk, nvme_ns_id_attr_groups); + if (device_add_disk(ctrl->device, ns->disk, nvme_ns_id_attr_groups)) + goto out_cleanup_ns_from_list; + if (!nvme_ns_head_multipath(ns->head)) nvme_add_ns_cdev(ns); @@ -3808,6 +3810,11 @@ static void nvme_alloc_ns(struct nvme_ctrl *ctrl, unsigned nsid, return; + out_cleanup_ns_from_list: + nvme_put_ctrl(ctrl); + down_write(&ctrl->namespaces_rwsem); + list_del_init(&ns->list); + up_write(&ctrl->namespaces_rwsem); out_unlink_ns: mutex_lock(&ctrl->subsys->lock); list_del_rcu(&ns->siblings); |