diff options
| author |   Bart Van Assche <bvanassche@acm.org> | 2018-10-08 14:28:49 -0700 |
|---|---|---|
| committer |   Christoph Hellwig <hch@lst.de> | 2018-10-17 08:58:24 +0200 |
| commit | 43a6f8fb619730fe5989e2430669626b2b5e13a0 (patch) | |
| tree | aac607454840ce2ebe94f20e982642ccbc906bd1 /drivers/nvme | |
| parent | nvmet: remove unreachable code (diff) | |
| download | linux-dev-43a6f8fb619730fe5989e2430669626b2b5e13a0.tar.xz linux-dev-43a6f8fb619730fe5989e2430669626b2b5e13a0.zip | |
nvmet: use strcmp() instead of strncmp() for subsystem lookup
strncmp() stops comparing when either the end of one of the first two arguments
is reached or when 'n' characters have been compared, whichever comes first.
That means that strncmp(s1, s2, n) is equivalent to strcmp(s1, s2) if n exceeds
the length of s1 or the length of s2. Since that is the case in
nvmet_find_get_subsys(), change strncmp() into strcmp(). This patch avoids that
the following warning is reported by smatch:
drivers/nvme/target/core.c:940:1 nvmet_find_get_subsys() error: strncmp() '"nqn.2014-08.org.nvmexpress.discovery"' too small (37 vs 223)
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'drivers/nvme')
| -rw-r--r-- | drivers/nvme/target/core.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c index b5ec96abd048..0acdff9e6842 100644 --- a/drivers/nvme/target/core.c +++ b/drivers/nvme/target/core.c @@ -1105,8 +1105,7 @@ static struct nvmet_subsys *nvmet_find_get_subsys(struct nvmet_port *port, if (!port) return NULL; - if (!strncmp(NVME_DISC_SUBSYS_NAME, subsysnqn, - NVMF_NQN_SIZE)) { + if (!strcmp(NVME_DISC_SUBSYS_NAME, subsysnqn)) { if (!kref_get_unless_zero(&nvmet_disc_subsys->ref)) return NULL; return nvmet_disc_subsys; |