diff options
| author |   Christoph Hellwig <hch@lst.de> | 2016-02-29 15:59:45 +0100 |
|---|---|---|
| committer |   Jens Axboe <axboe@fb.com> | 2016-02-29 08:47:14 -0700 |
| commit | 79f2b358c9ba373943a9284be2861fde58291c4e (patch) | |
| tree | f0c35f08d9937084dc0c1395c5d2790e7abc82c6 /drivers/nvme | |
| parent | nvme: use a work item to submit async event requests (diff) | |
| download | linux-dev-79f2b358c9ba373943a9284be2861fde58291c4e.tar.xz linux-dev-79f2b358c9ba373943a9284be2861fde58291c4e.zip | |
nvme: don't poll the CQ from the kthread
There is no reason to do unconditional polling of CQs per the NVMe
spec.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Keith Busch <keith.busch@intel.com>
Reviewed-by: Sagi Grimberg <sagig@mellanox.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'drivers/nvme')
| -rw-r--r-- | drivers/nvme/host/pci.c | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index 21b0be480fa5..10839f76179c 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -1156,9 +1156,6 @@ static struct nvme_queue *nvme_alloc_queue(struct nvme_dev *dev, int qid, nvmeq->qid = qid; nvmeq->cq_vector = -1; dev->queues[qid] = nvmeq; - - /* make sure queue descriptor is set before queue count, for kthread */ - mb(); dev->queue_count++; return nvmeq; @@ -1345,7 +1342,6 @@ static int nvme_kthread(void *data) set_current_state(TASK_INTERRUPTIBLE); spin_lock(&dev_list_lock); list_for_each_entry_safe(dev, next, &dev_list, node) { - int i; u32 csts = readl(dev->bar + NVME_REG_CSTS); /* @@ -1363,14 +1359,6 @@ static int nvme_kthread(void *data) } continue; } - for (i = 0; i < dev->queue_count; i++) { - struct nvme_queue *nvmeq = dev->queues[i]; - if (!nvmeq) - continue; - spin_lock_irq(&nvmeq->q_lock); - nvme_process_cq(nvmeq); - spin_unlock_irq(&nvmeq->q_lock); - } } spin_unlock(&dev_list_lock); schedule_timeout(round_jiffies_relative(HZ)); |