diff options
| author |   Max Gurtovoy <maxg@mellanox.com> | 2018-02-28 13:12:38 +0200 |
|---|---|---|
| committer |   Jens Axboe <axboe@kernel.dk> | 2018-03-26 08:53:43 -0600 |
| commit | a3dd7d0022c347207ae931c753a6dc3e6e8fcbc1 (patch) | |
| tree | 88895651a0ea808f9545de7a2ee7025370c6c305 /drivers/nvme | |
| parent | nvmet-rdma: Fix use after free in nvmet_rdma_cm_handler() (diff) | |
| download | linux-dev-a3dd7d0022c347207ae931c753a6dc3e6e8fcbc1.tar.xz linux-dev-a3dd7d0022c347207ae931c753a6dc3e6e8fcbc1.zip | |
nvmet-rdma: Don't flush system_wq by default during remove_one
The .remove_one function is called for any ib_device removal.
In case the removed device has no reference in our driver, there
is no need to flush the system work queue.
Reviewed-by: Israel Rukshin <israelr@mellanox.com>
Signed-off-by: Max Gurtovoy <maxg@mellanox.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Keith Busch <keith.busch@intel.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/nvme')
| -rw-r--r-- | drivers/nvme/target/rdma.c | 19 |
1 files changed, 18 insertions, 1 deletions
diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c index aa8068fce0dd..a59263d6d158 100644 --- a/drivers/nvme/target/rdma.c +++ b/drivers/nvme/target/rdma.c @@ -1469,8 +1469,25 @@ static struct nvmet_fabrics_ops nvmet_rdma_ops = { static void nvmet_rdma_remove_one(struct ib_device *ib_device, void *client_data) { struct nvmet_rdma_queue *queue, *tmp; + struct nvmet_rdma_device *ndev; + bool found = false; + + mutex_lock(&device_list_mutex); + list_for_each_entry(ndev, &device_list, entry) { + if (ndev->device == ib_device) { + found = true; + break; + } + } + mutex_unlock(&device_list_mutex); + + if (!found) + return; - /* Device is being removed, delete all queues using this device */ + /* + * IB Device that is used by nvmet controllers is being removed, + * delete all queues using this device. + */ mutex_lock(&nvmet_rdma_queue_mutex); list_for_each_entry_safe(queue, tmp, &nvmet_rdma_queue_list, queue_list) { |