diff options
| author |   Maurizio Lombardi <mlombard@redhat.com> | 2021-11-16 16:49:20 +0100 |
|---|---|---|
| committer |   Christoph Hellwig <hch@lst.de> | 2021-11-23 17:19:25 +0100 |
| commit | af21250bb503a02e705b461886321e394b300524 (patch) | |
| tree | 6d01107c0b484593cc706a8d01bb872464c31de7 /drivers/nvme | |
| parent | nvmet-tcp: add an helper to free the cmd buffers (diff) | |
| download | linux-dev-af21250bb503a02e705b461886321e394b300524.tar.xz linux-dev-af21250bb503a02e705b461886321e394b300524.zip | |
nvmet-tcp: fix memory leak when performing a controller reset
If a reset controller is executed while the initiator
is performing some I/O the driver may leak the memory allocated
for the commands' iovec.
Make sure that nvmet_tcp_uninit_data_in_cmds() releases
all the memory.
Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: John Meneghini <jmeneghi@redhat.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'drivers/nvme')
| -rw-r--r-- | drivers/nvme/target/tcp.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/nvme/target/tcp.c b/drivers/nvme/target/tcp.c index 786b1440a9af..605aa2a8ca53 100644 --- a/drivers/nvme/target/tcp.c +++ b/drivers/nvme/target/tcp.c @@ -1427,7 +1427,10 @@ static void nvmet_tcp_uninit_data_in_cmds(struct nvmet_tcp_queue *queue) for (i = 0; i < queue->nr_cmds; i++, cmd++) { if (nvmet_tcp_need_data_in(cmd)) - nvmet_tcp_finish_cmd(cmd); + nvmet_req_uninit(&cmd->req); + + nvmet_tcp_unmap_pdu_iovec(cmd); + nvmet_tcp_free_cmd_buffers(cmd); } if (!queue->nr_cmds && nvmet_tcp_need_data_in(&queue->connect)) { |