diff options
| author |   Geert Uytterhoeven <geert+renesas@glider.be> | 2017-11-27 15:46:27 +0100 |
|---|---|---|
| committer |   Rob Herring <robh@kernel.org> | 2017-12-06 14:56:32 -0600 |
| commit | 33acc40d00bc66f2d6e84441b6c46e03bd8acfa9 (patch) | |
| tree | 1094bef8f1c3d20a40baf4e94173adf6dec1201c /drivers/of | |
| parent | Linux 4.15-rc1 (diff) | |
| download | linux-dev-33acc40d00bc66f2d6e84441b6c46e03bd8acfa9.tar.xz linux-dev-33acc40d00bc66f2d6e84441b6c46e03bd8acfa9.zip | |
of: unittest: Remove bogus overlay mutex release from overlay_data_add()
overlay_data_add() never takes the special overlay mutex, so it must not
be released in the error patch.
Presumably the call to of_overlay_mutex_unlock() is a relic from v1 of
the patch.
Fixes: f948d6d8b792bb90 ("of: overlay: avoid race condition between applying multiple overlays")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Frank Rowand <frank.rowand@sony.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Diffstat (limited to 'drivers/of')
| -rw-r--r-- | drivers/of/unittest.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c index e568b1e82501..0f8052f1355c 100644 --- a/drivers/of/unittest.c +++ b/drivers/of/unittest.c @@ -2165,7 +2165,6 @@ static int __init overlay_data_add(int onum) ret = of_overlay_apply(info->np_overlay, &info->overlay_id); if (ret < 0) { pr_err("of_overlay_apply() (ret=%d), %d\n", ret, onum); - of_overlay_mutex_unlock(); goto out_free_np_overlay; } |