diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2019-09-25 14:01:00 +0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-09-27 10:19:09 +0200 |
| commit | d7eb651212fdbafa82d485d8e76095ac3b14c193 (patch) | |
| tree | a4beeffc5c6dba08e6455440f09f6fb3ba017e92 /drivers/of | |
| parent | net: axienet: fix a signedness bug in probe (diff) | |
| download | linux-dev-d7eb651212fdbafa82d485d8e76095ac3b14c193.tar.xz linux-dev-d7eb651212fdbafa82d485d8e76095ac3b14c193.zip | |
of: mdio: Fix a signedness bug in of_phy_get_and_connect()
The "iface" variable is an enum and in this context GCC treats it as
an unsigned int so the error handling is never triggered.
Fixes: b78624125304 ("of_mdio: Abstract a general interface for phy connect")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/of')
| -rw-r--r-- | drivers/of/of_mdio.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c index 000b95787df1..bd6129db6417 100644 --- a/drivers/of/of_mdio.c +++ b/drivers/of/of_mdio.c @@ -362,7 +362,7 @@ struct phy_device *of_phy_get_and_connect(struct net_device *dev, int ret; iface = of_get_phy_mode(np); - if (iface < 0) + if ((int)iface < 0) return NULL; if (of_phy_is_fixed_link(np)) { ret = of_phy_register_fixed_link(np); |