diff options
| author |   Viresh Kumar <viresh.kumar@linaro.org> | 2020-10-22 12:26:08 +0530 |
|---|---|---|
| committer | Viresh Kumar <viresh.kumar@linaro.org> | 2020-10-27 13:21:03 +0530 |
| commit | e0df59de670b48a923246fae1f972317b84b2764 (patch) | |
| tree | 8a449e6404c277d65197e0e4f042b1ac688c13f6 /drivers/opp/core.c | |
| parent | opp: Fix early exit from dev_pm_opp_register_set_opp_helper() (diff) | |
| download | linux-dev-e0df59de670b48a923246fae1f972317b84b2764.tar.xz linux-dev-e0df59de670b48a923246fae1f972317b84b2764.zip | |
opp: Reduce the size of critical section in _opp_table_kref_release()
There is a lot of stuff here which can be done outside of the big
opp_table_lock, do that. This helps avoiding few circular dependency
lockdeps around debugfs and interconnects.
Reported-by: Rob Clark <robdclark@gmail.com>
Reported-by: Dmitry Osipenko <digetx@gmail.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Diffstat (limited to 'drivers/opp/core.c')
| -rw-r--r-- | drivers/opp/core.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/drivers/opp/core.c b/drivers/opp/core.c index 4ac4e7ce6b8b..0e0a5269dc82 100644 --- a/drivers/opp/core.c +++ b/drivers/opp/core.c @@ -1181,6 +1181,10 @@ static void _opp_table_kref_release(struct kref *kref) struct opp_device *opp_dev, *temp; int i; + /* Drop the lock as soon as we can */ + list_del(&opp_table->node); + mutex_unlock(&opp_table_lock); + _of_clear_opp_table(opp_table); /* Release clk */ @@ -1208,10 +1212,7 @@ static void _opp_table_kref_release(struct kref *kref) mutex_destroy(&opp_table->genpd_virt_dev_lock); mutex_destroy(&opp_table->lock); - list_del(&opp_table->node); kfree(opp_table); - - mutex_unlock(&opp_table_lock); } void dev_pm_opp_put_opp_table(struct opp_table *opp_table) |