diff options
| author |   Rajendra Nayak <rnayak@codeaurora.org> | 2021-08-12 16:57:20 +0530 |
|---|---|---|
| committer |   Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2021-08-16 18:45:29 +0200 |
| commit | 020d86fc0df8b865f6dc168d88a7c2dccabd0a9e (patch) | |
| tree | 22a3cc15b9b68e5b4ee1efb02335d0df248a63df /drivers/opp | |
| parent | Linux 5.14-rc6 (diff) | |
| download | linux-dev-020d86fc0df8b865f6dc168d88a7c2dccabd0a9e.tar.xz linux-dev-020d86fc0df8b865f6dc168d88a7c2dccabd0a9e.zip | |
opp: Don't print an error if required-opps is missing
The 'required-opps' property is considered optional, hence remove
the pr_err() in of_parse_required_opp() when we find the property is
missing.
While at it, also fix the return value of
of_get_required_opp_performance_state() when of_parse_required_opp()
fails, return a -ENODEV instead of the -EINVAL.
Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'drivers/opp')
| -rw-r--r-- | drivers/opp/of.c | 12 |
1 files changed, 2 insertions, 10 deletions
diff --git a/drivers/opp/of.c b/drivers/opp/of.c index d298e38aaf7e..9bdabad11ca5 100644 --- a/drivers/opp/of.c +++ b/drivers/opp/of.c @@ -95,15 +95,7 @@ static struct dev_pm_opp *_find_opp_of_np(struct opp_table *opp_table, static struct device_node *of_parse_required_opp(struct device_node *np, int index) { - struct device_node *required_np; - - required_np = of_parse_phandle(np, "required-opps", index); - if (unlikely(!required_np)) { - pr_err("%s: Unable to parse required-opps: %pOF, index: %d\n", - __func__, np, index); - } - - return required_np; + return of_parse_phandle(np, "required-opps", index); } /* The caller must call dev_pm_opp_put_opp_table() after the table is used */ @@ -1327,7 +1319,7 @@ int of_get_required_opp_performance_state(struct device_node *np, int index) required_np = of_parse_required_opp(np, index); if (!required_np) - return -EINVAL; + return -ENODEV; opp_table = _find_table_of_opp_np(required_np); if (IS_ERR(opp_table)) { |