diff options
| author |   Miaoqian Lin <linmq006@gmail.com> | 2022-01-20 12:18:12 +0000 |
|---|---|---|
| committer |   Helge Deller <deller@gmx.de> | 2022-01-21 22:48:54 +0100 |
| commit | d24846a4246b6e61ecbd036880a4adf61681d241 (patch) | |
| tree | 28a9b63bb9fcc2149ab373d19380fb57464baf08 /drivers/parisc | |
| parent | parisc: Fix missing prototype for 'toc_intr' warning in toc.c (diff) | |
| download | linux-dev-d24846a4246b6e61ecbd036880a4adf61681d241.tar.xz linux-dev-d24846a4246b6e61ecbd036880a4adf61681d241.zip | |
parisc: pdc_stable: Fix memory leak in pdcs_register_pathentries
kobject_init_and_add() takes reference even when it fails.
According to the doc of kobject_init_and_add()：
If this function returns an error, kobject_put() must be called to
properly clean up the memory associated with the object.
Fix memory leak by calling kobject_put().
Fixes: 73f368cf679b ("Kobject: change drivers/parisc/pdc_stable.c to use kobject_init_and_add")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Helge Deller <deller@gmx.de>
Diffstat (limited to 'drivers/parisc')
| -rw-r--r-- | drivers/parisc/pdc_stable.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/parisc/pdc_stable.c b/drivers/parisc/pdc_stable.c index 9513c39719d1..d9e51036a4fa 100644 --- a/drivers/parisc/pdc_stable.c +++ b/drivers/parisc/pdc_stable.c @@ -980,8 +980,10 @@ pdcs_register_pathentries(void) entry->kobj.kset = paths_kset; err = kobject_init_and_add(&entry->kobj, &ktype_pdcspath, NULL, "%s", entry->name); - if (err) + if (err) { + kobject_put(&entry->kobj); return err; + } /* kobject is now registered */ write_lock(&entry->rw_lock); |