diff options
| author |   Julia Lawall <Julia.Lawall@lip6.fr> | 2018-07-12 22:29:55 +0100 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-07-15 14:13:00 +0200 |
| commit | faa1a47388b33623e4d504c23569188907b039a0 (patch) | |
| tree | be9c6dffb8fb64a4a2e6a2f80400180ca793189e /drivers/parport | |
| parent | eventpoll.h: wrap casts in () properly (diff) | |
| download | linux-dev-faa1a47388b33623e4d504c23569188907b039a0.tar.xz linux-dev-faa1a47388b33623e4d504c23569188907b039a0.zip | |
parport: sunbpp: fix error return code
Return an error code on failure. Change leading spaces to tab on the
first if.
Problem found using Coccinelle.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/parport')
| -rw-r--r-- | drivers/parport/parport_sunbpp.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/drivers/parport/parport_sunbpp.c b/drivers/parport/parport_sunbpp.c index 01cf1c1a841a..8de329546b82 100644 --- a/drivers/parport/parport_sunbpp.c +++ b/drivers/parport/parport_sunbpp.c @@ -286,12 +286,16 @@ static int bpp_probe(struct platform_device *op) ops = kmemdup(&parport_sunbpp_ops, sizeof(struct parport_operations), GFP_KERNEL); - if (!ops) + if (!ops) { + err = -ENOMEM; goto out_unmap; + } dprintk(("register_port\n")); - if (!(p = parport_register_port((unsigned long)base, irq, dma, ops))) + if (!(p = parport_register_port((unsigned long)base, irq, dma, ops))) { + err = -ENOMEM; goto out_free_ops; + } p->size = size; p->dev = &op->dev; |