diff options
author | 2018-03-28 13:50:06 +0200 | |
---|---|---|
committer | 2018-04-03 12:23:30 +0100 | |
commit | bf597574b6bee5ac741c58da763ad2f10df19065 (patch) | |
tree | 1b8f2ed4615897891dfd8a974f8a94e0e2c658d7 /drivers/pci/endpoint/pci-epc-core.c | |
parent | PCI: endpoint: Remove goto labels in pci_epf_create() (diff) | |
download | linux-dev-bf597574b6bee5ac741c58da763ad2f10df19065.tar.xz linux-dev-bf597574b6bee5ac741c58da763ad2f10df19065.zip |
PCI: endpoint: BAR width should not depend on sizeof dma_addr_t
If a BAR supports 64-bit width or not depends on the hardware,
and should thus not depend on sizeof(dma_addr_t).
If a certain hardware doesn't support 64-bit BARs, its
epc->ops->set_bar() implementation should return -EINVAL
when PCI_BASE_ADDRESS_MEM_TYPE_64 is set.
We can't change pci_epc_set_bar() to only set
PCI_BASE_ADDRESS_MEM_TYPE_64 based on size, since if the user,
for some reason, wants to configure a BAR with a 64-bit width,
even though the BAR size is less than 4 GB, he should be able
to do that.
However, since pci-epf-test is simply a test and not an API,
we can set PCI_BASE_ADDRESS_MEM_TYPE_64 in pci-epf-test itself
only based on size.
Signed-off-by: Niklas Cassel <niklas.cassel@axis.com>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
Diffstat (limited to 'drivers/pci/endpoint/pci-epc-core.c')
0 files changed, 0 insertions, 0 deletions