diff options
| author |   Robin Murphy <robin.murphy@arm.com> | 2018-12-06 13:20:49 -0800 |
|---|---|---|
| committer |   Christoph Hellwig <hch@lst.de> | 2018-12-13 21:06:13 +0100 |
| commit | e5361ca29f2fea345c08d2b5cb5e3b1840cbafb8 (patch) | |
| tree | 697be029cf1427e187d1547d376c719b185b632b /drivers/pci/pci-driver.c | |
| parent | dma-mapping: factor out dummy DMA ops (diff) | |
| download | linux-dev-e5361ca29f2fea345c08d2b5cb5e3b1840cbafb8.tar.xz linux-dev-e5361ca29f2fea345c08d2b5cb5e3b1840cbafb8.zip | |
ACPI / scan: Refactor _CCA enforcement
Rather than checking the DMA attribute at each callsite, just pass it
through for acpi_dma_configure() to handle directly. That can then deal
with the relatively exceptional DEV_DMA_NOT_SUPPORTED case by explicitly
installing dummy DMA ops instead of just skipping setup entirely. This
will then free up the dev->dma_ops == NULL case for some valuable
fastpath optimisations.
Signed-off-by: Robin Murphy <robin.murphy@arm.com>
Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
Tested-by: Jesper Dangaard Brouer <brouer@redhat.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Tested-by: Tony Luck <tony.luck@intel.com>
Diffstat (limited to 'drivers/pci/pci-driver.c')
| -rw-r--r-- | drivers/pci/pci-driver.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c index bef17c3fca67..1b58e058b13f 100644 --- a/drivers/pci/pci-driver.c +++ b/drivers/pci/pci-driver.c @@ -1602,8 +1602,7 @@ static int pci_dma_configure(struct device *dev) struct acpi_device *adev = to_acpi_device_node(bridge->fwnode); enum dev_dma_attr attr = acpi_get_dma_attr(adev); - if (attr != DEV_DMA_NOT_SUPPORTED) - ret = acpi_dma_configure(dev, attr); + ret = acpi_dma_configure(dev, acpi_get_dma_attr(adev)); } pci_put_host_bridge_device(bridge); |