diff options
| author |   Krzysztof Wilczyński <kw@linux.com> | 2020-08-24 23:39:16 +0000 |
|---|---|---|
| committer |   Bjorn Helgaas <bhelgaas@google.com> | 2020-09-01 14:04:55 -0500 |
| commit | e7a7499d841bfc9c7a4443f0fd7a04ae49bdbdd3 (patch) | |
| tree | 098e9c409d7ca0b9c00a6a09cad8fd2e57e81fd0 /drivers/pci/pci-sysfs.c | |
| parent | x86/PCI: Fix intel_mid_pci.c build error when ACPI is not enabled (diff) | |
| download | linux-dev-e7a7499d841bfc9c7a4443f0fd7a04ae49bdbdd3.tar.xz linux-dev-e7a7499d841bfc9c7a4443f0fd7a04ae49bdbdd3.zip | |
PCI: Use scnprintf(), not snprintf(), in sysfs "show" functions
Sysfs "show" methods should return the number of bytes printed into the
buffer. This is the return value of scnprintf() [1].
snprintf(buf, size, ...) prints at most "size" bytes into "buf", but
returns the number of bytes that *would* be printed if "buf" were large
enough.
Replace use of snprintf() with scnprintf(). No functional change intended.
Related:
https://patchwork.kernel.org/patch/9946759/#20969333
https://lwn.net/Articles/69419
[1] Documentation/filesystems/sysfs.rst
[bhelgaas: squashed, commit log]
Suggested-by: Bjorn Helgaas <bhelgaas@google.com>
Link: https://lore.kernel.org/r/20200824233918.26306-2-kw@linux.com
Link: https://lore.kernel.org/r/20200824233918.26306-3-kw@linux.com
Link: https://lore.kernel.org/r/20200824233918.26306-4-kw@linux.com
Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Diffstat (limited to 'drivers/pci/pci-sysfs.c')
| -rw-r--r-- | drivers/pci/pci-sysfs.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c index 6d78df981d41..ed66d387e913 100644 --- a/drivers/pci/pci-sysfs.c +++ b/drivers/pci/pci-sysfs.c @@ -574,7 +574,7 @@ static ssize_t driver_override_show(struct device *dev, ssize_t len; device_lock(dev); - len = snprintf(buf, PAGE_SIZE, "%s\n", pdev->driver_override); + len = scnprintf(buf, PAGE_SIZE, "%s\n", pdev->driver_override); device_unlock(dev); return len; } |