diff options
| author |   Bjorn Helgaas <bhelgaas@google.com> | 2013-04-12 11:35:40 -0600 |
|---|---|---|
| committer | Bjorn Helgaas <bhelgaas@google.com> | 2013-04-17 10:21:12 -0600 |
| commit | 9fc9eea09f518b9bbdc0a14ef668698c913ba614 (patch) | |
| tree | 3e1b6cb29f75de5b9a0aa1db371a6fc3332d2d07 /drivers/pci/slot.c | |
| parent | PCI: Remove __must_check from definitions (diff) | |
| download | linux-dev-9fc9eea09f518b9bbdc0a14ef668698c913ba614.tar.xz linux-dev-9fc9eea09f518b9bbdc0a14ef668698c913ba614.zip | |
PCI: Warn about failures instead of "must_check" functions
These places capture return values to avoid "must_check" warnings,
but we didn't *do* anything with the return values, which causes
"set but not used" warnings. We might as well do something instead
of just trying to evade the "must_check" warnings.
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Diffstat (limited to 'drivers/pci/slot.c')
| -rw-r--r-- | drivers/pci/slot.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/drivers/pci/slot.c b/drivers/pci/slot.c index ac6412fb8d6f..c1e9284a677b 100644 --- a/drivers/pci/slot.c +++ b/drivers/pci/slot.c @@ -377,14 +377,17 @@ void pci_hp_create_module_link(struct pci_slot *pci_slot) { struct hotplug_slot *slot = pci_slot->hotplug; struct kobject *kobj = NULL; - int no_warn; + int ret; if (!slot || !slot->ops) return; kobj = kset_find_obj(module_kset, slot->ops->mod_name); if (!kobj) return; - no_warn = sysfs_create_link(&pci_slot->kobj, kobj, "module"); + ret = sysfs_create_link(&pci_slot->kobj, kobj, "module"); + if (ret) + dev_err(&pci_slot->bus->dev, "Error creating sysfs link (%d)\n", + ret); kobject_put(kobj); } EXPORT_SYMBOL_GPL(pci_hp_create_module_link); |