diff options
| author |   Tony Lindgren <tony@atomide.com> | 2019-03-24 16:26:54 -0700 |
|---|---|---|
| committer |   Kishon Vijay Abraham I <kishon@ti.com> | 2019-04-17 10:29:49 +0530 |
| commit | 20f795881f4f186fd98d9425053d575b2e577ff5 (patch) | |
| tree | 1a36d52fd8f6fc16f6d09d1463c7251479282f3c /drivers/phy/rockchip | |
| parent | Linux 5.1-rc1 (diff) | |
| download | linux-dev-20f795881f4f186fd98d9425053d575b2e577ff5.tar.xz linux-dev-20f795881f4f186fd98d9425053d575b2e577ff5.zip | |
phy: phy-twl4030-usb: Fix cable state handling
With the recent regulator changes I noticed new warnings on doing rmmod of
phy-twl4030-usb:
WARNING: CPU: 0 PID: 1080 at drivers/regulator/core.c:2046 _regulator_put
...
Turns out we can currently miss disconnect at least for cases where status
is 0 and linkstat is 0. And in that case doing rmmod phy-twl4030-usb will
produce the regulator_put() warning.
This is because the missed disconnect causes unbalanced PM runtime calls
and the regulators will be on exit.
Let's fix the issue by using an atomic flag for the cable state to make
sure that PM runtime won't get out of sync with the cable state. That
way we can also simplify the code a bit.
Note that we can also drop the old comments, those relate to issues that
the battery charger driver and musb driver is dealing with rather than
the USB PHY driver.
Cc: NeilBrown <neilb@suse.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
Diffstat (limited to 'drivers/phy/rockchip')
0 files changed, 0 insertions, 0 deletions