diff options
| author |   Jules Maselbas <jmaselbas@kalray.eu> | 2022-04-07 12:21:08 +0200 |
|---|---|---|
| committer |   Vinod Koul <vkoul@kernel.org> | 2022-04-20 14:45:15 +0530 |
| commit | 1599069a62c6179fdde9f6e5b54d44531064a79c (patch) | |
| tree | d048757d3b45531cd62b5570a9fc302afc09655d /drivers/phy | |
| parent | phy: core: Update documentation syntax (diff) | |
| download | linux-dev-1599069a62c6179fdde9f6e5b54d44531064a79c.tar.xz linux-dev-1599069a62c6179fdde9f6e5b54d44531064a79c.zip | |
phy: core: Warn when phy_power_on is called before phy_init
A warning when the order of phy operation is mixed up by drivers,
this is an atempt to make the phy usage more uniform across (usb)
drivers.
Signed-off-by: Jules Maselbas <jmaselbas@kalray.eu>
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: Amelie DELAUNAY <amelie.delaunay@foss.st.com>
Cc: Minas Harutyunyan <hminas@synopsys.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>
Link: https://lore.kernel.org/r/20220407102108.24211-4-jmaselbas@kalray.eu
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/phy')
| -rw-r--r-- | drivers/phy/phy-core.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c index cbdad65d2caa..d93ddf1262c5 100644 --- a/drivers/phy/phy-core.c +++ b/drivers/phy/phy-core.c @@ -253,6 +253,9 @@ int phy_init(struct phy *phy) ret = 0; /* Override possible ret == -ENOTSUPP */ mutex_lock(&phy->mutex); + if (phy->power_count > phy->init_count) + dev_warn(&phy->dev, "phy_power_on was called before phy_init\n"); + if (phy->init_count == 0 && phy->ops->init) { ret = phy->ops->init(phy); if (ret < 0) { |