diff options
| author |   Wei Yongjun <weiyongjun1@huawei.com> | 2017-04-25 03:14:54 +0000 |
|---|---|---|
| committer |   Kishon Vijay Abraham I <kishon@ti.com> | 2017-05-19 14:13:39 +0530 |
| commit | 53bf9590151e06e3f74212fea8da2eca2385db76 (patch) | |
| tree | cb9ec61dcb011d5d5e22dcb2096cbbc35fbd3e23 /drivers/phy | |
| parent | Linux 4.12-rc1 (diff) | |
| download | linux-dev-53bf9590151e06e3f74212fea8da2eca2385db76.tar.xz linux-dev-53bf9590151e06e3f74212fea8da2eca2385db76.zip | |
phy: qcom-qmp: fix return value check in qcom_qmp_phy_create()
In case of error, the function of_iomap() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check should
be replaced with NULL test.
Fixes: e78f3d15e115 ("phy: qcom-qmp: new qmp phy driver for qcom-chipsets")
Reviewed-by: Vivek Gautam <vivek.gautam@codeaurora.org>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
Diffstat (limited to 'drivers/phy')
| -rw-r--r-- | drivers/phy/phy-qcom-qmp.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/drivers/phy/phy-qcom-qmp.c b/drivers/phy/phy-qcom-qmp.c index 727e23be7cac..a25c29d5fdf6 100644 --- a/drivers/phy/phy-qcom-qmp.c +++ b/drivers/phy/phy-qcom-qmp.c @@ -983,16 +983,16 @@ int qcom_qmp_phy_create(struct device *dev, struct device_node *np, int id) * Resources are indexed as: tx -> 0; rx -> 1; pcs -> 2. */ qphy->tx = of_iomap(np, 0); - if (IS_ERR(qphy->tx)) - return PTR_ERR(qphy->tx); + if (!qphy->tx) + return -ENOMEM; qphy->rx = of_iomap(np, 1); - if (IS_ERR(qphy->rx)) - return PTR_ERR(qphy->rx); + if (!qphy->rx) + return -ENOMEM; qphy->pcs = of_iomap(np, 2); - if (IS_ERR(qphy->pcs)) - return PTR_ERR(qphy->pcs); + if (!qphy->pcs) + return -ENOMEM; /* * Get PHY's Pipe clock, if any. USB3 and PCIe are PIPE3 |