diff options
| author |   Gustavo A. R. Silva <gustavo@embeddedor.com> | 2018-10-19 11:21:38 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-10-22 19:27:14 -0700 |
| commit | 6acb47d1a318e5b3b7115354ebc4ea060c59d3a1 (patch) | |
| tree | 0cfb067435cb242ef1b9e8eef53a4ab5285aaa49 /drivers/phy | |
| parent | dt-bindings: phy: Update SERDES_MAX to be SERDES_MAX + 1 (diff) | |
| download | linux-dev-6acb47d1a318e5b3b7115354ebc4ea060c59d3a1.tar.xz linux-dev-6acb47d1a318e5b3b7115354ebc4ea060c59d3a1.zip | |
phy: ocelot-serdes: fix out-of-bounds read
Currently, there is an out-of-bounds read on array ctrl->phys,
once variable i reaches the maximum array size of SERDES_MAX
in the for loop.
Fix this by changing the condition in the for loop from
i <= SERDES_MAX to i < SERDES_MAX.
Addresses-Coverity-ID: 1473966 ("Out-of-bounds read")
Addresses-Coverity-ID: 1473959 ("Out-of-bounds read")
Fixes: 51f6b410fc22 ("phy: add driver for Microsemi Ocelot SerDes muxing")
Reviewed-by: Quentin Schulz <quentin.schulz@bootlin.com>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/phy')
| -rw-r--r-- | drivers/phy/mscc/phy-ocelot-serdes.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/phy/mscc/phy-ocelot-serdes.c b/drivers/phy/mscc/phy-ocelot-serdes.c index b2be54680cf7..cbb49d9da6f9 100644 --- a/drivers/phy/mscc/phy-ocelot-serdes.c +++ b/drivers/phy/mscc/phy-ocelot-serdes.c @@ -206,7 +206,7 @@ static struct phy *serdes_simple_xlate(struct device *dev, port = args->args[0]; idx = args->args[1]; - for (i = 0; i <= SERDES_MAX; i++) { + for (i = 0; i < SERDES_MAX; i++) { struct serdes_macro *macro = phy_get_drvdata(ctrl->phys[i]); if (idx != macro->idx) @@ -260,7 +260,7 @@ static int serdes_probe(struct platform_device *pdev) if (IS_ERR(ctrl->regs)) return PTR_ERR(ctrl->regs); - for (i = 0; i <= SERDES_MAX; i++) { + for (i = 0; i < SERDES_MAX; i++) { ret = serdes_phy_create(ctrl, i, &ctrl->phys[i]); if (ret) return ret; |