diff options
| author |   Nishka Dasgupta <nishkadg.linux@gmail.com> | 2019-07-23 16:19:19 +0530 |
|---|---|---|
| committer |   Kishon Vijay Abraham I <kishon@ti.com> | 2019-08-23 09:40:52 +0530 |
| commit | 8d160f6b491ec2bcfba2233121ab81f0424e133f (patch) | |
| tree | 394d7217ca25261ea794ab230e65d1ed291c24da /drivers/phy | |
| parent | phy: enable compile-testing for the Lantiq PHY drivers (diff) | |
| download | linux-dev-8d160f6b491ec2bcfba2233121ab81f0424e133f.tar.xz linux-dev-8d160f6b491ec2bcfba2233121ab81f0424e133f.zip | |
phy: marvell: phy-armada38x-comphy: Add of_node_put() before return
Each iteration of for_each_available_child_of_node puts the previous
node, but in the case of a return from the middle of the loop, there is
no put, thus causing a memory leak. Hence add an of_node_put before the
return.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
Diffstat (limited to 'drivers/phy')
| -rw-r--r-- | drivers/phy/marvell/phy-armada38x-comphy.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/phy/marvell/phy-armada38x-comphy.c b/drivers/phy/marvell/phy-armada38x-comphy.c index 3e00bc679d4e..6960dfd8ad8c 100644 --- a/drivers/phy/marvell/phy-armada38x-comphy.c +++ b/drivers/phy/marvell/phy-armada38x-comphy.c @@ -200,8 +200,10 @@ static int a38x_comphy_probe(struct platform_device *pdev) } phy = devm_phy_create(&pdev->dev, child, &a38x_comphy_ops); - if (IS_ERR(phy)) + if (IS_ERR(phy)) { + of_node_put(child); return PTR_ERR(phy); + } priv->lane[val].base = base + 0x28 * val; priv->lane[val].priv = priv; |