diff options
| author |   Yang Li <yang.lee@linux.alibaba.com> | 2021-02-25 17:17:54 +0800 |
|---|---|---|
| committer |   Vinod Koul <vkoul@kernel.org> | 2021-03-30 23:35:17 +0530 |
| commit | f26fde369c3d59e5711ff35a08c244888db137bb (patch) | |
| tree | 3fc9ad079dc602686201571268b5ef96111239eb /drivers/phy | |
| parent | phy: ralink: phy-mt7621-pci: fix XTAL bitmask (diff) | |
| download | linux-dev-f26fde369c3d59e5711ff35a08c244888db137bb.tar.xz linux-dev-f26fde369c3d59e5711ff35a08c244888db137bb.zip | |
phy: ti: j721e-wiz: add missing call to of_node_put()
In one of the error paths of the for_each_child_of_node() loop in
of_property_read_u32, add missing call to of_node_put().
Fix the following coccicheck warning:
./drivers/phy/ti/phy-j721e-wiz.c:786:1-23: WARNING: Function
"for_each_child_of_node" should have of_node_put() before return around
line 795.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Link: https://lore.kernel.org/r/1614244674-66556-1-git-send-email-yang.lee@linux.alibaba.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/phy')
| -rw-r--r-- | drivers/phy/ti/phy-j721e-wiz.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wiz.c index 124a3eddd189..3c003f9d0b6f 100644 --- a/drivers/phy/ti/phy-j721e-wiz.c +++ b/drivers/phy/ti/phy-j721e-wiz.c @@ -1104,6 +1104,7 @@ static int wiz_get_lane_phy_types(struct device *dev, struct wiz *wiz) ret = of_property_read_u32(subnode, "reg", ®); if (ret) { + of_node_put(subnode); dev_err(dev, "%s: Reading \"reg\" from \"%s\" failed: %d\n", __func__, subnode->name, ret); |