diff options
| author |   Zhen Lei <thunder.leizhen@huawei.com> | 2021-05-11 16:51:26 +0800 |
|---|---|---|
| committer |   Linus Walleij <linus.walleij@linaro.org> | 2021-05-20 01:37:32 +0200 |
| commit | ef9385fbf30e9484e4291db76e000b8961419782 (patch) | |
| tree | 023796c8fa4453da6655b94963b40ea51d94b2c1 /drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | |
| parent | pinctrl: ocelot: Remove redundant error printing in ocelot_pinctrl_probe() (diff) | |
| download | linux-dev-ef9385fbf30e9484e4291db76e000b8961419782.tar.xz linux-dev-ef9385fbf30e9484e4291db76e000b8961419782.zip | |
pinctrl: iproc-gpio: Remove redundant error printing in iproc_gpio_probe()
When devm_ioremap_resource() fails, a clear enough error message will be
printed by its subfunction __devm_ioremap_resource(). The error
information contains the device name, failure cause, and possibly resource
information.
Therefore, remove the error printing here to simplify code and reduce the
binary size.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Acked-by: Ray Jui <ray.jui@broadcom.com>
Link: https://lore.kernel.org/r/20210511085126.4287-1-thunder.leizhen@huawei.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl/bcm/pinctrl-iproc-gpio.c')
| -rw-r--r-- | drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c index e2bd2dce6bb4..dc511b9a6b43 100644 --- a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c +++ b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c @@ -813,10 +813,8 @@ static int iproc_gpio_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 1); if (res) { chip->io_ctrl = devm_ioremap_resource(dev, res); - if (IS_ERR(chip->io_ctrl)) { - dev_err(dev, "unable to map I/O memory\n"); + if (IS_ERR(chip->io_ctrl)) return PTR_ERR(chip->io_ctrl); - } if (of_device_is_compatible(dev->of_node, "brcm,cygnus-ccm-gpio")) io_ctrl_type = IOCTRL_TYPE_CDRU; |