diff options
| author |   Wei Yongjun <weiyongjun1@huawei.com> | 2018-07-11 12:34:21 +0000 |
|---|---|---|
| committer |   Linus Walleij <linus.walleij@linaro.org> | 2018-07-14 12:47:04 +0200 |
| commit | c29e9da56bebb4c2c794e871b0dc0298bbf08142 (patch) | |
| tree | 0c10481b45fd941058be61d76cc48f23fcee5e94 /drivers/pinctrl/bcm | |
| parent | pinctrl: nsp: off by ones in nsp_pinmux_enable() (diff) | |
| download | linux-dev-c29e9da56bebb4c2c794e871b0dc0298bbf08142.tar.xz linux-dev-c29e9da56bebb4c2c794e871b0dc0298bbf08142.zip | |
pinctrl: nsp: Fix potential NULL dereference
platform_get_resource() may fail and return NULL, so we should
better check it's return value to avoid a NULL pointer dereference
a bit later in the code.
This is detected by Coccinelle semantic patch.
@@
expression pdev, res, n, t, e, e1, e2;
@@
res = platform_get_resource(pdev, t, n);
+ if (!res)
+ return -EINVAL;
... when != res == NULL
e = devm_ioremap_nocache(e1, res->start, e2);
Fixes: cc4fa83f66e9 ("pinctrl: nsp: add pinmux driver support for Broadcom NSP SoC")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Ray Jui <ray.jui@broadcom.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl/bcm')
| -rw-r--r-- | drivers/pinctrl/bcm/pinctrl-nsp-mux.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/pinctrl/bcm/pinctrl-nsp-mux.c b/drivers/pinctrl/bcm/pinctrl-nsp-mux.c index 5cd8166fbbc8..87618a4e90e4 100644 --- a/drivers/pinctrl/bcm/pinctrl-nsp-mux.c +++ b/drivers/pinctrl/bcm/pinctrl-nsp-mux.c @@ -577,6 +577,8 @@ static int nsp_pinmux_probe(struct platform_device *pdev) return PTR_ERR(pinctrl->base0); res = platform_get_resource(pdev, IORESOURCE_MEM, 1); + if (!res) + return -EINVAL; pinctrl->base1 = devm_ioremap_nocache(&pdev->dev, res->start, resource_size(res)); if (!pinctrl->base1) { |