diff options
| author |   Nishka Dasgupta <nishkadg.linux@gmail.com> | 2019-08-04 21:21:54 +0530 |
|---|---|---|
| committer |   Linus Walleij <linus.walleij@linaro.org> | 2019-08-06 14:51:59 +0200 |
| commit | f452444709c07ea5d126e9f312f602ac9c5e34fd (patch) | |
| tree | c9958957244b3fdc8fe86d6e5b191c64146e1946 /drivers/pinctrl/nomadik | |
| parent | pinctrl: nomadik: nomadik: Add of_node_put() before return (diff) | |
| download | linux-dev-f452444709c07ea5d126e9f312f602ac9c5e34fd.tar.xz linux-dev-f452444709c07ea5d126e9f312f602ac9c5e34fd.zip | |
pinctrl: nomadik: abx500: Add of_node_put() before return
Each iteration of for_each_child_of_node puts the previous node, but in
the case of a return from the middle of the loop, there is no put, thus
causing a memory leak. Hence add an of_node_put before the return.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Link: https://lore.kernel.org/r/20190804155154.4916-1-nishkadg.linux@gmail.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl/nomadik')
| -rw-r--r-- | drivers/pinctrl/nomadik/pinctrl-abx500.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/pinctrl/nomadik/pinctrl-abx500.c b/drivers/pinctrl/nomadik/pinctrl-abx500.c index c3595200e1e6..7aa534576a45 100644 --- a/drivers/pinctrl/nomadik/pinctrl-abx500.c +++ b/drivers/pinctrl/nomadik/pinctrl-abx500.c @@ -815,6 +815,7 @@ static int abx500_dt_node_to_map(struct pinctrl_dev *pctldev, &reserved_maps, num_maps); if (ret < 0) { pinctrl_utils_free_map(pctldev, *map, *num_maps); + of_node_put(np); return ret; } } |