aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/pinctrl/pinconf.c
diff options
context:
space:
mode:
authorDong Aisheng <dong.aisheng@linaro.org>2012-04-10 12:41:34 +0800
committerLinus Walleij <linus.walleij@linaro.org>2012-04-18 13:53:11 +0200
commitad8bb720c23a80233e45ed31d67458f5e5b7ab31 (patch)
tree6b1da7d3dc99bacd03167a0235785e3f881b03b3 /drivers/pinctrl/pinconf.c
parentpinctrl: fix pinmux_check_ops error checking (diff)
downloadlinux-dev-ad8bb720c23a80233e45ed31d67458f5e5b7ab31.tar.xz
linux-dev-ad8bb720c23a80233e45ed31d67458f5e5b7ab31.zip
pinctrl: add some error checking for user interfaces
This patch can avoid kernel oops in case the mux or config function is not supported by driver. Acked-by: Stephen Warren <swarren@wwwdotorg.org> Signed-off-by: Dong Aisheng <dong.aisheng@linaro.org> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl/pinconf.c')
-rw-r--r--drivers/pinctrl/pinconf.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/pinctrl/pinconf.c b/drivers/pinctrl/pinconf.c
index eb3a14f4b866..384dcc166e44 100644
--- a/drivers/pinctrl/pinconf.c
+++ b/drivers/pinctrl/pinconf.c
@@ -448,8 +448,12 @@ static void pinconf_dump_pin(struct pinctrl_dev *pctldev,
static int pinconf_pins_show(struct seq_file *s, void *what)
{
struct pinctrl_dev *pctldev = s->private;
+ const struct pinconf_ops *ops = pctldev->desc->confops;
unsigned i, pin;
+ if (!ops || !ops->pin_config_get)
+ return 0;
+
seq_puts(s, "Pin config settings per pin\n");
seq_puts(s, "Format: pin (name): pinmux setting array\n");