diff options
| author |   Alexandre Belloni <alexandre.belloni@bootlin.com> | 2018-03-22 13:35:00 +0100 |
|---|---|---|
| committer |   Linus Walleij <linus.walleij@linaro.org> | 2018-03-26 11:04:48 +0200 |
| commit | 44edff1bbc48595a041f65a725203763e3590a73 (patch) | |
| tree | 4414df946cfb0cd3c7423edf70b658a026b5c7af /drivers/pinctrl/pinctrl-ocelot.c | |
| parent | pinctrl: mtk: fix check warnings. (diff) | |
| download | linux-dev-44edff1bbc48595a041f65a725203763e3590a73.tar.xz linux-dev-44edff1bbc48595a041f65a725203763e3590a73.zip | |
pinctrl: ocelot: fix gpio direction
Bits have to be cleared in DEVCPU_GCB:GPIO:GPIO_OE for input and set for
output. ocelot_gpio_set_direction() got it wrong and this went unnoticed
when the driver was reworked.
Reported-by: Gregory Clement <gregory.clement@bootlin.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Acked-by: Gregory CLEMENT <gregory.clement@bootlin.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl/pinctrl-ocelot.c')
| -rw-r--r-- | drivers/pinctrl/pinctrl-ocelot.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/pinctrl/pinctrl-ocelot.c b/drivers/pinctrl/pinctrl-ocelot.c index a9423238471e..b5b3547fdcb2 100644 --- a/drivers/pinctrl/pinctrl-ocelot.c +++ b/drivers/pinctrl/pinctrl-ocelot.c @@ -252,7 +252,7 @@ static int ocelot_gpio_set_direction(struct pinctrl_dev *pctldev, struct ocelot_pinctrl *info = pinctrl_dev_get_drvdata(pctldev); regmap_update_bits(info->map, OCELOT_GPIO_OE, BIT(pin), - input ? BIT(pin) : 0); + input ? 0 : BIT(pin)); return 0; } |