diff options
| author |   Wen Yang <wen.yang99@zte.com.cn> | 2019-04-15 14:24:02 +0800 |
|---|---|---|
| committer |   Linus Walleij <linus.walleij@linaro.org> | 2019-05-23 09:24:46 +0200 |
| commit | 3c89c70634bb0b6f48512de873e7a45c7e1fbaa5 (patch) | |
| tree | 2d353b262765c4c2d9e5f1efd6fff9ca03dace5d /drivers/pinctrl/pinctrl-rockchip.c | |
| parent | Linux 5.2-rc1 (diff) | |
| download | linux-dev-3c89c70634bb0b6f48512de873e7a45c7e1fbaa5.tar.xz linux-dev-3c89c70634bb0b6f48512de873e7a45c7e1fbaa5.zip | |
pinctrl: rockchip: fix leaked of_node references
The call to of_parse_phandle returns a node pointer with refcount
incremented thus it must be explicitly decremented after the last
usage.
Detected by coccinelle with the following warnings:
./drivers/pinctrl/pinctrl-rockchip.c:3221:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 3196, but without a corresponding object release within this function.
./drivers/pinctrl/pinctrl-rockchip.c:3223:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 3196, but without a corresponding object release within this function.
Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: linux-gpio@vger.kernel.org
Cc: linux-rockchip@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl/pinctrl-rockchip.c')
| -rw-r--r-- | drivers/pinctrl/pinctrl-rockchip.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c index 16bf21bf69a2..64363363fe27 100644 --- a/drivers/pinctrl/pinctrl-rockchip.c +++ b/drivers/pinctrl/pinctrl-rockchip.c @@ -3212,6 +3212,7 @@ static int rockchip_get_bank_data(struct rockchip_pin_bank *bank, base, &rockchip_regmap_config); } + of_node_put(node); } bank->irq = irq_of_parse_and_map(bank->of_node, 0); |