diff options
| author |   Ludovic Desroches <ludovic.desroches@atmel.com> | 2015-06-08 17:16:37 +0200 |
|---|---|---|
| committer |   Linus Walleij <linus.walleij@linaro.org> | 2015-06-10 10:44:05 +0200 |
| commit | 9d7ebbbf2264c4ad3c8d50fcb84952126184a7ad (patch) | |
| tree | f9b10b71062bfb95a9e82afab792dce5f6e33dcf /drivers/pinctrl/pinmux.c | |
| parent | pinctrl: dt-binding: Add DT binding documentation for MSM8660 (diff) | |
| download | linux-dev-9d7ebbbf2264c4ad3c8d50fcb84952126184a7ad.tar.xz linux-dev-9d7ebbbf2264c4ad3c8d50fcb84952126184a7ad.zip | |
pinctrl: don't print unavailable function groups
There is no reason to try to print groups associated to a function if
get_function_groups returns an error. Moreover, it can lead to a NULL
pointer dereference error.
Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl/pinmux.c')
| -rw-r--r-- | drivers/pinctrl/pinmux.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/pinctrl/pinmux.c b/drivers/pinctrl/pinmux.c index 77f82b23f7be..e7ae890dcf1a 100644 --- a/drivers/pinctrl/pinmux.c +++ b/drivers/pinctrl/pinmux.c @@ -557,9 +557,12 @@ static int pinmux_functions_show(struct seq_file *s, void *what) ret = pmxops->get_function_groups(pctldev, func_selector, &groups, &num_groups); - if (ret) + if (ret) { seq_printf(s, "function %s: COULD NOT GET GROUPS\n", func); + func_selector++; + continue; + } seq_printf(s, "function: %s, groups = [ ", func); for (i = 0; i < num_groups; i++) |