diff options
| author |   Geert Uytterhoeven <geert+renesas@glider.be> | 2015-03-12 11:09:15 +0100 |
|---|---|---|
| committer |   Linus Walleij <linus.walleij@linaro.org> | 2015-03-18 02:14:45 +0100 |
| commit | 17c7cbb0e7b7a877f1ce2063d7f869801b24cd6a (patch) | |
| tree | 7406be08e11a14e9cdc6c315262ffec6cd7c8353 /drivers/pinctrl | |
| parent | pinctrl: sh-pfc: Use unsigned int for register/field widths and offsets (diff) | |
| download | linux-dev-17c7cbb0e7b7a877f1ce2063d7f869801b24cd6a.tar.xz linux-dev-17c7cbb0e7b7a877f1ce2063d7f869801b24cd6a.zip | |
pinctrl: sh-pfc: Use reg_width instead of reg as sentinel
All other loops over sh_pfc_soc_info.data_regs[] use
pinmux_data_reg.regwidth as the sentinel, which is safer as zero is
never a valid regwidth value (reg could be zero if we start using it to
store an offset).
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl')
| -rw-r--r-- | drivers/pinctrl/sh-pfc/gpio.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/pinctrl/sh-pfc/gpio.c b/drivers/pinctrl/sh-pfc/gpio.c index aa2fc77a1925..5d3a35ce0912 100644 --- a/drivers/pinctrl/sh-pfc/gpio.c +++ b/drivers/pinctrl/sh-pfc/gpio.c @@ -84,7 +84,7 @@ static void gpio_setup_data_reg(struct sh_pfc_chip *chip, unsigned idx) unsigned int bit; unsigned int i; - for (i = 0, dreg = pfc->info->data_regs; dreg->reg; ++i, ++dreg) { + for (i = 0, dreg = pfc->info->data_regs; dreg->reg_width; ++i, ++dreg) { for (bit = 0; bit < dreg->reg_width; bit++) { if (dreg->enum_ids[bit] == pin->enum_id) { gpio_pin->dreg = i; |