diff options
| author |   Hans de Goede <hdegoede@redhat.com> | 2021-02-04 12:38:48 +0100 |
|---|---|---|
| committer | Hans de Goede <hdegoede@redhat.com> | 2021-02-04 13:23:55 +0100 |
| commit | f807f4b7b32db00fc8622289644362e0695989bb (patch) | |
| tree | 3855f86f3888d000b0dbca0531efc4bc9a26c0ec /drivers/platform/surface | |
| parent | platform/x86: Move all dell drivers to their own subdirectory (diff) | |
| download | linux-dev-f807f4b7b32db00fc8622289644362e0695989bb.tar.xz linux-dev-f807f4b7b32db00fc8622289644362e0695989bb.zip | |
platform/surface: surface3-wmi: Fix variable 'status' set but not used compiler warning
Explicitly check the status rather then relying on output.pointer staying
NULL on an error. This silences the following compiler warning:
drivers/platform/surface/surface3-wmi.c:60:14: warning: variable 'status' set but not used [-Wunused-but-set-variable]
Reported-by: kernel test robot <lkp@intel.com>
Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20210204113848.105994-1-hdegoede@redhat.com
Diffstat (limited to 'drivers/platform/surface')
| -rw-r--r-- | drivers/platform/surface/surface3-wmi.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/platform/surface/surface3-wmi.c b/drivers/platform/surface/surface3-wmi.c index 130b6f52a600..fcd1d4fb94d5 100644 --- a/drivers/platform/surface/surface3-wmi.c +++ b/drivers/platform/surface/surface3-wmi.c @@ -57,12 +57,16 @@ static DEFINE_MUTEX(s3_wmi_lock); static int s3_wmi_query_block(const char *guid, int instance, int *ret) { struct acpi_buffer output = { ACPI_ALLOCATE_BUFFER, NULL }; + union acpi_object *obj = NULL; acpi_status status; - union acpi_object *obj; int error = 0; mutex_lock(&s3_wmi_lock); status = wmi_query_block(guid, instance, &output); + if (ACPI_FAILURE(status)) { + error = -EIO; + goto out_free_unlock; + } obj = output.pointer; |