aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/platform/x86/thinkpad_acpi.c
diff options
context:
space:
mode:
authorHans de Goede <hdegoede@redhat.com>2022-03-09 18:05:32 +0100
committerHans de Goede <hdegoede@redhat.com>2022-03-09 18:17:57 +0100
commit10b29dd7eafe1987b44866d3ee1d0d71bf622cb3 (patch)
tree120585a0853f856ca93cf9a6bff4c119daa30871 /drivers/platform/x86/thinkpad_acpi.c
parentplatform/x86: thinkpad_acpi: Fix compiler warning about uninitialized err variable (diff)
downloadlinux-dev-10b29dd7eafe1987b44866d3ee1d0d71bf622cb3.tar.xz
linux-dev-10b29dd7eafe1987b44866d3ee1d0d71bf622cb3.zip
platform/x86: thinkpad_acpi: Don't use test_bit on an integer
test_bit can only be used on longs not on ints, fix this. Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by: Hans de Goede <hdegoede@redhat.com> Link: https://lore.kernel.org/r/20220309170532.343384-2-hdegoede@redhat.com
Diffstat (limited to 'drivers/platform/x86/thinkpad_acpi.c')
-rw-r--r--drivers/platform/x86/thinkpad_acpi.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index 7016c7fc3440..c476a78599d6 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -10399,7 +10399,7 @@ static int tpacpi_dytc_profile_init(struct ibm_init_struct *iibm)
if (err)
return err;
- if (test_bit(DYTC_FC_MMC, (void *)&output)) { /* MMC MODE */
+ if (output & BIT(DYTC_FC_MMC)) { /* MMC MODE */
dytc_profile_available = DYTC_FUNCMODE_MMC;
/*
@@ -10412,7 +10412,7 @@ static int tpacpi_dytc_profile_init(struct ibm_init_struct *iibm)
if (!err && ((output & DYTC_ERR_MASK) == DYTC_ERR_SUCCESS))
dytc_mmc_get_available = true;
}
- } else if (test_bit(DYTC_FC_PSC, (void *)&output)) { /*PSC MODE */
+ } else if (output & BIT(DYTC_FC_PSC)) { /* PSC MODE */
dytc_profile_available = DYTC_FUNCMODE_PSC;
} else {
dbg_printk(TPACPI_DBG_INIT, "No DYTC support available\n");