diff options
| author |   Qing Wang <wangqing@vivo.com> | 2021-10-14 23:50:40 -0700 |
|---|---|---|
| committer |   Hans de Goede <hdegoede@redhat.com> | 2021-10-19 16:59:44 +0200 |
| commit | 2d5b0755b754fcb39598df87b3a8656a569e9979 (patch) | |
| tree | d228e132733c4f5f3c7a255e9dceb6147aefd06b /drivers/platform | |
| parent | platform: x86: ideapad-laptop: Use ACPI_COMPANION() directly (diff) | |
| download | linux-dev-2d5b0755b754fcb39598df87b3a8656a569e9979.tar.xz linux-dev-2d5b0755b754fcb39598df87b3a8656a569e9979.zip | |
platform/x86: panasonic-laptop: Replace snprintf in show functions with sysfs_emit
show() must not use snprintf() when formatting the value to be
returned to user space.
Fix the coccicheck warnings:
WARNING: use scnprintf or sprintf.
Use sysfs_emit instead of scnprintf or sprintf makes more sense.
Signed-off-by: Qing Wang <wangqing@vivo.com>
Link: https://lore.kernel.org/r/1634280641-4862-1-git-send-email-wangqing@vivo.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Diffstat (limited to 'drivers/platform')
| -rw-r--r-- | drivers/platform/x86/panasonic-laptop.c | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/drivers/platform/x86/panasonic-laptop.c b/drivers/platform/x86/panasonic-laptop.c index d4f444401496..37850d07987d 100644 --- a/drivers/platform/x86/panasonic-laptop.c +++ b/drivers/platform/x86/panasonic-laptop.c @@ -470,7 +470,7 @@ static ssize_t numbatt_show(struct device *dev, struct device_attribute *attr, if (!acpi_pcc_retrieve_biosdata(pcc)) return -EIO; - return snprintf(buf, PAGE_SIZE, "%u\n", pcc->sinf[SINF_NUM_BATTERIES]); + return sysfs_emit(buf, "%u\n", pcc->sinf[SINF_NUM_BATTERIES]); } static ssize_t lcdtype_show(struct device *dev, struct device_attribute *attr, @@ -482,7 +482,7 @@ static ssize_t lcdtype_show(struct device *dev, struct device_attribute *attr, if (!acpi_pcc_retrieve_biosdata(pcc)) return -EIO; - return snprintf(buf, PAGE_SIZE, "%u\n", pcc->sinf[SINF_LCD_TYPE]); + return sysfs_emit(buf, "%u\n", pcc->sinf[SINF_LCD_TYPE]); } static ssize_t mute_show(struct device *dev, struct device_attribute *attr, @@ -494,7 +494,7 @@ static ssize_t mute_show(struct device *dev, struct device_attribute *attr, if (!acpi_pcc_retrieve_biosdata(pcc)) return -EIO; - return snprintf(buf, PAGE_SIZE, "%u\n", pcc->sinf[SINF_MUTE]); + return sysfs_emit(buf, "%u\n", pcc->sinf[SINF_MUTE]); } static ssize_t mute_store(struct device *dev, struct device_attribute *attr, @@ -524,7 +524,7 @@ static ssize_t sticky_key_show(struct device *dev, struct device_attribute *attr if (!acpi_pcc_retrieve_biosdata(pcc)) return -EIO; - return snprintf(buf, PAGE_SIZE, "%u\n", pcc->sticky_key); + return sysfs_emit(buf, "%u\n", pcc->sticky_key); } static ssize_t sticky_key_store(struct device *dev, struct device_attribute *attr, @@ -566,7 +566,7 @@ static ssize_t eco_mode_show(struct device *dev, struct device_attribute *attr, result = -EIO; break; } - return snprintf(buf, PAGE_SIZE, "%u\n", result); + return sysfs_emit(buf, "%u\n", result); } static ssize_t eco_mode_store(struct device *dev, struct device_attribute *attr, @@ -625,7 +625,7 @@ static ssize_t ac_brightness_show(struct device *dev, struct device_attribute *a if (!acpi_pcc_retrieve_biosdata(pcc)) return -EIO; - return snprintf(buf, PAGE_SIZE, "%u\n", pcc->sinf[SINF_AC_CUR_BRIGHT]); + return sysfs_emit(buf, "%u\n", pcc->sinf[SINF_AC_CUR_BRIGHT]); } static ssize_t ac_brightness_store(struct device *dev, struct device_attribute *attr, @@ -655,7 +655,7 @@ static ssize_t dc_brightness_show(struct device *dev, struct device_attribute *a if (!acpi_pcc_retrieve_biosdata(pcc)) return -EIO; - return snprintf(buf, PAGE_SIZE, "%u\n", pcc->sinf[SINF_DC_CUR_BRIGHT]); + return sysfs_emit(buf, "%u\n", pcc->sinf[SINF_DC_CUR_BRIGHT]); } static ssize_t dc_brightness_store(struct device *dev, struct device_attribute *attr, @@ -685,7 +685,7 @@ static ssize_t current_brightness_show(struct device *dev, struct device_attribu if (!acpi_pcc_retrieve_biosdata(pcc)) return -EIO; - return snprintf(buf, PAGE_SIZE, "%u\n", pcc->sinf[SINF_CUR_BRIGHT]); + return sysfs_emit(buf, "%u\n", pcc->sinf[SINF_CUR_BRIGHT]); } static ssize_t current_brightness_store(struct device *dev, struct device_attribute *attr, @@ -710,7 +710,7 @@ static ssize_t current_brightness_store(struct device *dev, struct device_attrib static ssize_t cdpower_show(struct device *dev, struct device_attribute *attr, char *buf) { - return snprintf(buf, PAGE_SIZE, "%d\n", get_optd_power_state()); + return sysfs_emit(buf, "%d\n", get_optd_power_state()); } static ssize_t cdpower_store(struct device *dev, struct device_attribute *attr, |