diff options
| author |   Souvik Kumar Chakravarty <souvik.k.chakravarty@intel.com> | 2016-02-17 12:05:22 +0530 |
|---|---|---|
| committer |   Darren Hart <dvhart@linux.intel.com> | 2016-03-23 10:05:46 -0700 |
| commit | 479f3b62d6d05cf74427f61fbd92b1a54c8645aa (patch) | |
| tree | 673ff2431172ba9a07d011d2a67c9101d2b434f0 /drivers/platform | |
| parent | dell-rbtn: Add a comment about the XPS 13 9350 (diff) | |
| download | linux-dev-479f3b62d6d05cf74427f61fbd92b1a54c8645aa.tar.xz linux-dev-479f3b62d6d05cf74427f61fbd92b1a54c8645aa.zip | |
intel_telemetry_pltdrv: Change verbosity control bits
Due to a recent fix in the firmware, the Punit verbosity control bits
now adhere to the correct pattern. Hence remove the workaround and
do a read-modify-write of the register.
Signed-off-by: Souvik Kumar Chakravarty <souvik.k.chakravarty@intel.com>
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
Diffstat (limited to 'drivers/platform')
| -rw-r--r-- | drivers/platform/x86/intel_telemetry_pltdrv.c | 13 |
1 files changed, 12 insertions, 1 deletions
diff --git a/drivers/platform/x86/intel_telemetry_pltdrv.c b/drivers/platform/x86/intel_telemetry_pltdrv.c index f97019b0106f..397119f83e82 100644 --- a/drivers/platform/x86/intel_telemetry_pltdrv.c +++ b/drivers/platform/x86/intel_telemetry_pltdrv.c @@ -1030,8 +1030,19 @@ static int telemetry_plt_set_trace_verbosity(enum telemetry_unit telem_unit, switch (telem_unit) { case TELEM_PSS: ret = intel_punit_ipc_command( + IPC_PUNIT_BIOS_READ_TELE_TRACE_CTRL, + 0, 0, NULL, &temp); + if (ret) { + pr_err("PSS TRACE_CTRL Read Failed\n"); + goto out; + } + + TELEM_CLEAR_VERBOSITY_BITS(temp); + TELEM_SET_VERBOSITY_BITS(temp, verbosity); + + ret = intel_punit_ipc_command( IPC_PUNIT_BIOS_WRITE_TELE_TRACE_CTRL, - 0, 0, &verbosity, NULL); + 0, 0, &temp, NULL); if (ret) { pr_err("PSS TRACE_CTRL Verbosity Set Failed\n"); goto out; |