diff options
| author |   Tim Crawford <tcrawford@system76.com> | 2021-10-30 09:42:13 -0600 |
|---|---|---|
| committer |   Hans de Goede <hdegoede@redhat.com> | 2021-11-02 11:23:55 +0100 |
| commit | 97ae45953ea957887170078f488fd629dd1ce786 (patch) | |
| tree | 8f32a8be2d18ff3a6303c094d904c2dcbb5209cc /drivers/platform | |
| parent | platform/x86: touchscreen_dmi: Add info for the Viglen Connect 10 tablet (diff) | |
| download | linux-dev-97ae45953ea957887170078f488fd629dd1ce786.tar.xz linux-dev-97ae45953ea957887170078f488fd629dd1ce786.zip | |
platform/x86: system76_acpi: Fix input device error handling
Users on darp6 that do not have Open EC firmware have reported crashes
on boot. Correct the error handling for the input device to fix it.
Managed devices do not need to be explicitly unregistered or freed, as
this is handled by devres. Drop the call to input_free_device.
Fixes: 0de30fc684b3 ("platform/x86: system76_acpi: Replace Fn+F2 function for OLED models")
Signed-off-by: Tim Crawford <tcrawford@system76.com>
Link: https://lore.kernel.org/r/20211030154213.2515-1-tcrawford@system76.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Diffstat (limited to 'drivers/platform')
| -rw-r--r-- | drivers/platform/x86/system76_acpi.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/platform/x86/system76_acpi.c b/drivers/platform/x86/system76_acpi.c index b3c8178420b1..8b292ee95a14 100644 --- a/drivers/platform/x86/system76_acpi.c +++ b/drivers/platform/x86/system76_acpi.c @@ -739,7 +739,6 @@ static int system76_add(struct acpi_device *acpi_dev) error: kfree(data->ntmp); kfree(data->nfan); - input_free_device(data->input); return err; } |