diff options
| author |   Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm> | 2021-09-14 14:18:05 +0200 |
|---|---|---|
| committer |   Sebastian Reichel <sre@kernel.org> | 2021-10-12 17:59:05 +0200 |
| commit | 0cf48167b87e388fa1268c9fe6d2443ae7f43d8a (patch) | |
| tree | eb9a2c7cbc33c7742cb8189f71dc52ec7e10e215 /drivers/power | |
| parent | MAINTAINERS: power: supply: max17040: add entry with reviewers (diff) | |
| download | linux-dev-0cf48167b87e388fa1268c9fe6d2443ae7f43d8a.tar.xz linux-dev-0cf48167b87e388fa1268c9fe6d2443ae7f43d8a.zip | |
power: supply: max17042_battery: Clear status bits in interrupt handler
The gauge requires us to clear the status bits manually for some alerts
to be properly dismissed. Previously the IRQ was configured to react only
on falling edge, which wasn't technically correct (the ALRT line is active
low), but it had a happy side-effect of preventing interrupt storms
on uncleared alerts from happening.
Fixes: 7fbf6b731bca ("power: supply: max17042: Do not enforce (incorrect) interrupt trigger type")
Cc: <stable@vger.kernel.org>
Signed-off-by: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Diffstat (limited to 'drivers/power')
| -rw-r--r-- | drivers/power/supply/max17042_battery.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/power/supply/max17042_battery.c b/drivers/power/supply/max17042_battery.c index 32f331480487..2eb61856f3e4 100644 --- a/drivers/power/supply/max17042_battery.c +++ b/drivers/power/supply/max17042_battery.c @@ -879,6 +879,10 @@ static irqreturn_t max17042_thread_handler(int id, void *dev) max17042_set_soc_threshold(chip, 1); } + /* we implicitly handle all alerts via power_supply_changed */ + regmap_clear_bits(chip->regmap, MAX17042_STATUS, + 0xFFFF & ~(STATUS_POR_BIT | STATUS_BST_BIT)); + power_supply_changed(chip->battery); return IRQ_HANDLED; } |