aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/powercap
diff options
context:
space:
mode:
authorDaniel Lezcano <daniel.lezcano@linaro.org>2020-12-30 16:37:44 +0100
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>2020-12-30 18:47:33 +0100
commit8f50db4b5c79af2ba54f5fbe8a5173fd7f37a493 (patch)
treebbe4b57cb2e2b7fcafcb58005bf2b716a546ab3f /drivers/powercap
parentpowercap/drivers/dtpm: Add CPU energy model based support (diff)
downloadlinux-dev-8f50db4b5c79af2ba54f5fbe8a5173fd7f37a493.tar.xz
linux-dev-8f50db4b5c79af2ba54f5fbe8a5173fd7f37a493.zip
powercap/drivers/dtpm: Fix __udivdi3 and __aeabi_uldivmod unresolved symbols
32-bit architectures do not support u64 divisions, so the macro DIV_ROUND_CLOSEST is not adequate as the compiler will replace the call to an unexisting function for the platform, leading to unresolved references to symbols. Fix this by using the compatible macros: DIV64_U64_ROUND_CLOSEST and DIV_ROUND_CLOSEST_ULL. Fixes: a20d0ef97abf ("powercap/drivers/dtpm: Add API for dynamic thermal power management") Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'drivers/powercap')
-rw-r--r--drivers/powercap/dtpm.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/powercap/dtpm.c b/drivers/powercap/dtpm.c
index 5b6857e9b064..0abcc439d728 100644
--- a/drivers/powercap/dtpm.c
+++ b/drivers/powercap/dtpm.c
@@ -99,8 +99,8 @@ static void __dtpm_rebalance_weight(struct dtpm *dtpm)
pr_debug("Setting weight '%d' for '%s'\n",
child->weight, child->zone.name);
- child->weight = DIV_ROUND_CLOSEST(child->power_max * 1024,
- dtpm->power_max);
+ child->weight = DIV64_U64_ROUND_CLOSEST(
+ child->power_max * 1024, dtpm->power_max);
__dtpm_rebalance_weight(child);
}
@@ -272,7 +272,7 @@ static int __set_power_limit_uw(struct dtpm *dtpm, int cid, u64 power_limit)
} else if (power_limit == dtpm->power_min) {
power = child->power_min;
} else {
- power = DIV_ROUND_CLOSEST(
+ power = DIV_ROUND_CLOSEST_ULL(
power_limit * child->weight, 1024);
}