diff options
author | Tom Rix <trix@redhat.com> | 2022-03-05 10:13:46 -0800 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2022-03-07 12:26:53 +0000 |
commit | 57d29a2935c9aab0aaef6264bf6a58aad3859e7c (patch) | |
tree | 14dd865f56e08c9e7d6aa5ea9c15d841c004cb18 /drivers/ptp/ptp_ocp.c | |
parent | net: dsa: return success if there was nothing to do (diff) | |
download | linux-dev-57d29a2935c9aab0aaef6264bf6a58aad3859e7c.tar.xz linux-dev-57d29a2935c9aab0aaef6264bf6a58aad3859e7c.zip |
net: rtnetlink: fix error handling in rtnl_fill_statsinfo()
The clang static analyzer reports this issue
rtnetlink.c:5481:2: warning: Undefined or garbage
value returned to caller
return err;
^~~~~~~~~~
There is a function level err variable, in the
list_for_each_entry_rcu block there is a shadow
err. Remove the shadow.
In the same block, the call to nla_nest_start_noflag()
can fail without setting an err. Set the err
to -EMSGSIZE.
Fixes: 216e690631f5 ("net: rtnetlink: rtnl_fill_statsinfo(): Permit non-EMSGSIZE error returns")
Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: Petr Machata <petrm@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/ptp/ptp_ocp.c')
0 files changed, 0 insertions, 0 deletions