diff options
| author |   Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2021-05-12 13:15:29 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2021-05-12 14:06:33 -0700 |
| commit | 9c1bb37f8cad5e2ee1933fa1da9a6baa7876a8e4 (patch) | |
| tree | a679480ce04a1f8874e04139be63827ea8078849 /drivers/ptp | |
| parent | octeontx2-pf: fix a buffer overflow in otx2_set_rxfh_context() (diff) | |
| download | linux-dev-9c1bb37f8cad5e2ee1933fa1da9a6baa7876a8e4.tar.xz linux-dev-9c1bb37f8cad5e2ee1933fa1da9a6baa7876a8e4.zip | |
ptp: ocp: Fix a resource leak in an error handling path
If an error occurs after a successful 'pci_ioremap_bar()' call, it must be
undone by a corresponding 'pci_iounmap()' call, as already done in the
remove function.
Fixes: a7e1abad13f3 ("ptp: Add clock driver for the OpenCompute TimeCard.")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Richard Cochran <richardcochran@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/ptp')
| -rw-r--r-- | drivers/ptp/ptp_ocp.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c index 530e5f90095e..0d1034e3ed0f 100644 --- a/drivers/ptp/ptp_ocp.c +++ b/drivers/ptp/ptp_ocp.c @@ -324,7 +324,7 @@ ptp_ocp_probe(struct pci_dev *pdev, const struct pci_device_id *id) if (!bp->base) { dev_err(&pdev->dev, "io_remap bar0\n"); err = -ENOMEM; - goto out; + goto out_release_regions; } bp->reg = bp->base + OCP_REGISTER_OFFSET; bp->tod = bp->base + TOD_REGISTER_OFFSET; @@ -347,6 +347,8 @@ ptp_ocp_probe(struct pci_dev *pdev, const struct pci_device_id *id) return 0; out: + pci_iounmap(pdev, bp->base); +out_release_regions: pci_release_regions(pdev); out_disable: pci_disable_device(pdev); |