diff options
| author |   Lee Jones <lee.jones@linaro.org> | 2020-06-29 13:47:49 +0100 |
|---|---|---|
| committer |   Thierry Reding <thierry.reding@gmail.com> | 2020-07-30 11:27:11 +0200 |
| commit | 9443f2c88ad916cad7efcd40fabc3e8c33c98594 (patch) | |
| tree | 1519837f75a309c52af88f6822eaa72577bb2823 /drivers/pwm/pwm-bcm-iproc.c | |
| parent | pwm: iqs620a: Use lowercase hexadecimal literals for consistency (diff) | |
| download | linux-dev-9443f2c88ad916cad7efcd40fabc3e8c33c98594.tar.xz linux-dev-9443f2c88ad916cad7efcd40fabc3e8c33c98594.zip | |
pwm: bcm-iproc: Remove impossible comparison when validating duty cycle
'duty' here is an unsigned int, thus checking for <0 will always
evaluate to false.
Fixes the following W=1 warning:
drivers/pwm/pwm-bcm-iproc.c:147:12: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
Cc: Ray Jui <rjui@broadcom.com>
Cc: Scott Branden <sbranden@broadcom.com>
Cc: Yendapally Reddy Dhananjaya Reddy <yendapally.reddy@broadcom.com>
Cc: bcm-kernel-feedback-list@broadcom.com
Cc: linux-pwm@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
Diffstat (limited to 'drivers/pwm/pwm-bcm-iproc.c')
| -rw-r--r-- | drivers/pwm/pwm-bcm-iproc.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/pwm/pwm-bcm-iproc.c b/drivers/pwm/pwm-bcm-iproc.c index 1f829edd8ee7..46f0a45e9049 100644 --- a/drivers/pwm/pwm-bcm-iproc.c +++ b/drivers/pwm/pwm-bcm-iproc.c @@ -143,8 +143,7 @@ static int iproc_pwmc_apply(struct pwm_chip *chip, struct pwm_device *pwm, value = rate * state->duty_cycle; duty = div64_u64(value, div); - if (period < IPROC_PWM_PERIOD_MIN || - duty < IPROC_PWM_DUTY_CYCLE_MIN) + if (period < IPROC_PWM_PERIOD_MIN) return -EINVAL; if (period <= IPROC_PWM_PERIOD_MAX && |